Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18977 )
Change subject: IMPALA-10408: Support build using Apache components ...................................................................... Patch Set 15: (4 comments) Good to know the build succeeds! > I have one question. Why does impala use toolchains from cloudera internal > repository when building? It is called "Apache Impala" and open source. It > should be built with apache sources. I think we used to support building on Apache components. But due to the official releases are usually slow (e.g. Hive-4.0), we switch to build on CDH/CDP components which have the bug fixes or improvements to unblock our work. > It will be easier to build apache impala if there is a way to download or > upload binary packages for apache components like > https://github.com/zer0beat/apache-ranger-compiled/releases for Apache Ranger. We can consider uploading this to the S3 bucket of our native-toolchain. An alternative is building Apache Ranger in bin/bootstrap_system.sh if it doesn't take long. We used to build hadoop-lzo there in 3.x (it's removed later since we deprecated the support on LZO). http://gerrit.cloudera.org:8080/#/c/18977/15//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18977/15//COMMIT_MSG@8 PS15, Line 8: Could you add some notes as the commit message? E.g. overview of this patch, what problems you have solved, what tests you have done, etc. Just like other commits do. http://gerrit.cloudera.org:8080/#/c/18977/15/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/18977/15/bin/impala-config.sh@249 PS15, Line 249: \export APACHE_HADOOP_VERSION=3.3.6 Redundant backslash "\" http://gerrit.cloudera.org:8080/#/c/18977/15/bin/impala-config.sh@358 PS15, Line 358: USE_APACHE nit: Can we use a more concrete name, e.g. USE_APACHE_BUILDS, USE_APACHE_BINARIES, or USE_APACHE_COMPONENTS ? http://gerrit.cloudera.org:8080/#/c/18977/15/java/TableFlattener/pom.xml File java/TableFlattener/pom.xml: http://gerrit.cloudera.org:8080/#/c/18977/15/java/TableFlattener/pom.xml@67 PS15, Line 67: <dependency> : <groupId>commons-lang</groupId> : <artifactId>commons-lang</artifactId> : <version>${commons-io.version}</version> : </dependency> Is this added for some reason? Could you mention the compilation error without it in the commit message? -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 15 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 22 Apr 2024 11:02:37 +0000 Gerrit-HasComments: Yes
