Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21302 )
Change subject: IMPALA-13005: Create Query Live table in HMS ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/21302/2/be/src/service/workload-management.cc File be/src/service/workload-management.cc: http://gerrit.cloudera.org:8080/#/c/21302/2/be/src/service/workload-management.cc@116 PS2, Line 116: ble by generati > Yes, that's why I changed them. I guess I can do that instead. According to Done http://gerrit.cloudera.org:8080/#/c/21302/2/common/thrift/SystemTables.thrift File common/thrift/SystemTables.thrift: http://gerrit.cloudera.org:8080/#/c/21302/2/common/thrift/SystemTables.thrift@23 PS2, Line 23: CLUSTER_ID : QUERY_ID > Just going to go back to unassigned. There's a DCHECK that asserts these ar Done http://gerrit.cloudera.org:8080/#/c/21302/2/fe/src/main/java/org/apache/impala/catalog/SystemTable.java File fe/src/main/java/org/apache/impala/catalog/SystemTable.java: http://gerrit.cloudera.org:8080/#/c/21302/2/fe/src/main/java/org/apache/impala/catalog/SystemTable.java@59 PS2, Line 59: TImpalaTableProperty.__IMPALA_SYSTEM_TABLE.toString()); > I don't think so. I was looking at DataSourceTable for this pattern. Added to CatalogObjects.thrift. http://gerrit.cloudera.org:8080/#/c/21302/4/fe/src/main/java/org/apache/impala/catalog/SystemTable.java File fe/src/main/java/org/apache/impala/catalog/SystemTable.java: http://gerrit.cloudera.org:8080/#/c/21302/4/fe/src/main/java/org/apache/impala/catalog/SystemTable.java@59 PS4, Line 59: TImpalaTableProperty.__IMPALA_SYSTEM_TABLE.toString()); > Yeah, I think const string with TBL_PROP_ prefix is better. A property key Done -- To view, visit http://gerrit.cloudera.org:8080/21302 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf302ee54a819fdee2db0ae582a5eeddffe4a5b4 Gerrit-Change-Number: 21302 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 18 Apr 2024 21:20:34 +0000 Gerrit-HasComments: Yes
