Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21292 )
Change subject: IMPALA-12996: Add support for DATE in Iceberg metadata tables ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21292/2/be/src/exec/iceberg-metadata/iceberg-row-reader.cc File be/src/exec/iceberg-metadata/iceberg-row-reader.cc: http://gerrit.cloudera.org:8080/#/c/21292/2/be/src/exec/iceberg-metadata/iceberg-row-reader.cc@97 PS2, Line 97: TYPE_DATE This shouldn't cause issue in practice, but it would be better to validate the integer's range. DataValue functions assume that the value is in the valid range or set to invalid. See the constructor at https://github.com/apache/impala/blob/0334f837048301f5670808711e627384e38dab61/be/src/runtime/date-value.h#L63 -- To view, visit http://gerrit.cloudera.org:8080/21292 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2223385f90555b1f9b22f3e27fa0e2489c3b9b5 Gerrit-Change-Number: 21292 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 12 Apr 2024 12:57:49 +0000 Gerrit-HasComments: Yes
