Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20131 )
Change subject: IMPALA-12152: Add query option to wait for events sync up ...................................................................... Patch Set 16: (1 comment) PS15 switches to the new solution. Commit message is updated accordingly. http://gerrit.cloudera.org:8080/#/c/20131/14/tests/metadata/test_event_processing_base.py File tests/metadata/test_event_processing_base.py: http://gerrit.cloudera.org:8080/#/c/20131/14/tests/metadata/test_event_processing_base.py@30 PS14, Line 30: def _run_test_insert_events_impl(cls, hive_client, impala_client, impala_cluster, > nit: either this doesn't need to inherit from ImpalaTestSuite, or you could This class uses some methods of ImpalaTestSuite like run_stmt_in_hive(), execute_query_expect_success(), execute_scalar_expect_success(). We can make those methods static and use them directly, But I think it's simpler to inherit ImpalaTestSuite directly. For the skipIf annotations, I think we can remove them since there are no tests in this class (i.e. nothing to skip). -- To view, visit http://gerrit.cloudera.org:8080/20131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36ac941bb2c2217b09fcfa2eb567b011b38efa2a Gerrit-Change-Number: 20131 Gerrit-PatchSet: 16 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Sat, 06 Apr 2024 13:23:20 +0000 Gerrit-HasComments: Yes
