Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/21218 )
Change subject: IMPALA-12925: Fix decimal data type for external JDBC table ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/21218/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21218/5//COMMIT_MSG@16 PS5, Line 16: less than the decimal scales of the corresponding columns in the table Is it just scale or precision also? I think we should enforce both. http://gerrit.cloudera.org:8080/#/c/21218/5/fe/src/main/java/org/apache/impala/extdatasource/jdbc/dao/JdbcRecordIterator.java File fe/src/main/java/org/apache/impala/extdatasource/jdbc/dao/JdbcRecordIterator.java: http://gerrit.cloudera.org:8080/#/c/21218/5/fe/src/main/java/org/apache/impala/extdatasource/jdbc/dao/JdbcRecordIterator.java@154 PS5, Line 154: if (scalarType.scale < valScale) { We should probably check both scale and precision here since Impala does enforce strict conversion from Decimal to Decimal. https://impala.apache.org/docs/build/html/topics/impala_decimal.html Updating test cases to capture this will also be good. -- To view, visit http://gerrit.cloudera.org:8080/21218 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c9d2e0667c42c0e52436b158e3dfe3ec14b9e3b Gerrit-Change-Number: 21218 Gerrit-PatchSet: 5 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Wed, 03 Apr 2024 18:09:51 +0000 Gerrit-HasComments: Yes
