Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21171 )
Change subject: IMPALA-12905: Disk-based tuple caching ...................................................................... Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/21171/6/be/src/exec/tuple-cache-node.cc File be/src/exec/tuple-cache-node.cc: http://gerrit.cloudera.org:8080/#/c/21171/6/be/src/exec/tuple-cache-node.cc@33 PS6, Line 33: DECLARE_bool(allow_tuple_caching); Is this flag actually used here? http://gerrit.cloudera.org:8080/#/c/21171/6/be/src/exec/tuple-cache-node.cc@180 PS6, Line 180: // TODO: is this needed for Reset too? Do we need to support Reset? http://gerrit.cloudera.org:8080/#/c/21171/6/be/src/exec/tuple-file-reader.cc File be/src/exec/tuple-file-reader.cc: http://gerrit.cloudera.org:8080/#/c/21171/6/be/src/exec/tuple-file-reader.cc@89 PS6, Line 89: // TODO: more detailed error messages. May need to check for failure immediately This would be nice to address. http://gerrit.cloudera.org:8080/#/c/21171/6/be/src/exec/tuple-file-writer.cc File be/src/exec/tuple-file-writer.cc: http://gerrit.cloudera.org:8080/#/c/21171/6/be/src/exec/tuple-file-writer.cc@79 PS6, Line 79: // TODO: swap write order of data/offsets since all the functions use offsets first. I don't remember what this todo meant, we can probably get rid of it. http://gerrit.cloudera.org:8080/#/c/21171/6/be/src/exec/tuple-file-writer.cc@91 PS6, Line 91: // TODO: more detailed error messages. May need to check for failure immediately Would be nice to address. http://gerrit.cloudera.org:8080/#/c/21171/6/be/src/runtime/tuple-cache-mgr.cc File be/src/runtime/tuple-cache-mgr.cc: http://gerrit.cloudera.org:8080/#/c/21171/6/be/src/runtime/tuple-cache-mgr.cc@101 PS6, Line 101: "The tuple_cache parameter can only be specified if allow_tuple_caching=true."); I'm trying to make sense of why we made it work this way. Wouldn't it be useful to be able to enable/disable tuple caching without clearing tuple_cache? If not, why do we have both flags? -- To view, visit http://gerrit.cloudera.org:8080/21171 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13a65c4c0559cad3559d5f714a074dd06e9cc9bf Gerrit-Change-Number: 21171 Gerrit-PatchSet: 6 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 28 Mar 2024 21:50:36 +0000 Gerrit-HasComments: Yes
