Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21171 )
Change subject: PROTOTYPE: IMPALA-12905: Disk-based tuple caching ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/21171/1/be/src/runtime/tuple-cache-mgr.cc File be/src/runtime/tuple-cache-mgr.cc: http://gerrit.cloudera.org:8080/#/c/21171/1/be/src/runtime/tuple-cache-mgr.cc@240 PS1, Line 240: // Insert into the cache. If immediately evicted, evict_callback_ handles cleanup and line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/21171/1/tests/custom_cluster/test_tuple_cache.py File tests/custom_cluster/test_tuple_cache.py: http://gerrit.cloudera.org:8080/#/c/21171/1/tests/custom_cluster/test_tuple_cache.py@27 PS1, Line 27: def table_value(seed): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/21171/1/tests/custom_cluster/test_tuple_cache.py@35 PS1, Line 35: def assertCounters(profile, num_hits, num_halted, num_skipped): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/21171/1/tests/custom_cluster/test_tuple_cache.py@40 PS1, Line 40: class TestTupleCache(CustomClusterTestSuite): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/21171/1/tests/custom_cluster/test_tuple_cache.py@48 PS1, Line 48: flake8: E201 whitespace after '{' http://gerrit.cloudera.org:8080/#/c/21171/1/tests/custom_cluster/test_tuple_cache.py@48 PS1, Line 48: flake8: E202 whitespace before '}' -- To view, visit http://gerrit.cloudera.org:8080/21171 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13a65c4c0559cad3559d5f714a074dd06e9cc9bf Gerrit-Change-Number: 21171 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 20 Mar 2024 05:42:14 +0000 Gerrit-HasComments: Yes
