Xiang Yang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21128 )
Change subject: IMPALA-12264: Add limit on number of HS2 sessions per user. ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/21128/1/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/21128/1/be/src/service/impala-hs2-server.cc@491 PS1, Line 491: if (FLAGS_max_hs2_sessions_per_user > 0 maybe we should pull this line at top of the function to avoid unnecessary lock. http://gerrit.cloudera.org:8080/#/c/21128/1/be/src/service/impala-hs2-server.cc@492 PS1, Line 492: && load + 1 > FLAGS_max_hs2_sessions_per_user) { nit:we can replace it to 'load >= FLAGS_max_hs2_sessions_per_user' to avoid doing addition. http://gerrit.cloudera.org:8080/#/c/21128/1/be/src/service/impala-hs2-server.cc@493 PS1, Line 493: return Status::Expected("Number of sessions for user exceeds coordinator limit"); should we log some message here? and should we return the threshold to the client? -- To view, visit http://gerrit.cloudera.org:8080/21128 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd28edc352102d89774f6ece5376e7c79ae41aa8 Gerrit-Change-Number: 21128 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Comment-Date: Thu, 14 Mar 2024 14:28:12 +0000 Gerrit-HasComments: Yes
