Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21118 )
Change subject: IMPALA-12881: Use getFkPkJoinCardinality to reduce scan cardinality ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/21118/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21118/3//COMMIT_MSG@19 PS3, Line 19: Runtime filters that evaluate at scan node at : row level will keep using JoinNode.computeGenericJoinCardinality(). > I don't get the reasoning behind this - if the runtime filter is estimated In IMPALA-12018, I don't make distinction on whether a runtime filter still need to materialize row in scan node (row-level filter) or not (partition filter). I initially tried to replace computeGenericJoinCardinality() entirely with getFkPkJoinCardinality(), but then I see underestimation in few cases. It looks like row-level runtime filter is either late or disabled by scan node due to ineffectiveness. This is the reason why this patch only use getFkPkJoinCardinality() (that result in lower cardinality estimation) for partition filter or pushed-down Kudu filter only. http://gerrit.cloudera.org:8080/#/c/21118/3//COMMIT_MSG@21 PS3, Line 21: : Testi > All the test changes I checked are about HDFS tables. As the change should Will check other planner tests. http://gerrit.cloudera.org:8080/#/c/21118/3/testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/tpcds-q04.test File testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/tpcds-q04.test: http://gerrit.cloudera.org:8080/#/c/21118/3/testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/tpcds-q04.test@a178 PS3, Line 178: > What change leads to skipping the "filtered from" part in the plan? I think it was off-by-1 due to rounding. -- To view, visit http://gerrit.cloudera.org:8080/21118 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6efafffc8f96247a860b88e85d9097b2b4327f32 Gerrit-Change-Number: 21118 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 13 Mar 2024 17:30:09 +0000 Gerrit-HasComments: Yes
