Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21131 )
Change subject: IMPALA-11499: Refactor UrlEncode function to handle special characters ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/21131/1/be/src/util/coding-util.cc File be/src/util/coding-util.cc: http://gerrit.cloudera.org:8080/#/c/21131/1/be/src/util/coding-util.cc@47 PS1, Line 47: static function<bool (char)> HiveShouldEscape = is_any_of("\"#%\\*/:=?\u00FF"); With this change it doesn't look like we need this list or ShouldNotEscape anymore, specialCharacterMap covers it. http://gerrit.cloudera.org:8080/#/c/21131/1/be/src/util/coding-util.cc@84 PS1, Line 84: boost::replace_all(input_str, std::string(1, entry.first), entry.second); So this works because it only replaces specific chars - that won't appear in multi-byte characters - rather than anything that's not isalnum? http://gerrit.cloudera.org:8080/#/c/21131/1/be/src/util/coding-util.cc@95 PS1, Line 95: } We could return unused capacity with https://en.cppreference.com/w/cpp/string/basic_string/shrink_to_fit. -- To view, visit http://gerrit.cloudera.org:8080/21131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88c4aba5d811dfcec809583d0c16fcbc0ca730fb Gerrit-Change-Number: 21131 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Mon, 11 Mar 2024 20:29:27 +0000 Gerrit-HasComments: Yes
