Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 )
Change subject: IMPALA-12426: Query History Table ...................................................................... Patch Set 39: (7 comments) http://gerrit.cloudera.org:8080/#/c/20770/39/be/src/service/query-state-record.cc File be/src/service/query-state-record.cc: http://gerrit.cloudera.org:8080/#/c/20770/39/be/src/service/query-state-record.cc@208 PS39, Line 208: base_state->num_rows_fetched = exec_state.num_rows_fetched_counter(); Nice, I'd noticed base could be null and fixed it in my patch. http://gerrit.cloudera.org:8080/#/c/20770/39/be/src/service/workload-management.h File be/src/service/workload-management.h: http://gerrit.cloudera.org:8080/#/c/20770/39/be/src/service/workload-management.h@42 PS39, Line 42: const std::string DB = "sys"; This is going to allocate storage every place the header is included. Do we really need to define it in the header? http://gerrit.cloudera.org:8080/#/c/20770/39/be/src/service/workload-management.h@51 PS39, Line 51: std::uint32_t max_values_length; This should still be extern, or it won't use the right value in all cases. http://gerrit.cloudera.org:8080/#/c/20770/39/be/src/service/workload-management.h@105 PS39, Line 105: const FieldParser fp) : db_column_name(db_col_name), db_column_type(db_col_type), These should be `std::move`'d in to place. Right now it's making 2 copies of each string as part of initialization. http://gerrit.cloudera.org:8080/#/c/20770/36/be/src/service/workload-management.cc File be/src/service/workload-management.cc: http://gerrit.cloudera.org:8080/#/c/20770/36/be/src/service/workload-management.cc@61 PS36, Line 61: Decided this didn't need to be configurable? http://gerrit.cloudera.org:8080/#/c/20770/39/be/src/service/workload-management.cc File be/src/service/workload-management.cc: http://gerrit.cloudera.org:8080/#/c/20770/39/be/src/service/workload-management.cc@206 PS39, Line 206: }(); This is still evaluated during static initialization, before query_log_write_interval_s is set. http://gerrit.cloudera.org:8080/#/c/20770/39/be/src/service/workload-management.cc@354 PS39, Line 354: _fq_table = StrCat(DB, ".", FLAGS_query_log_table_name); Does this actually need to be a global? Looks like it's only used in this function or methods called from it. -- To view, visit http://gerrit.cloudera.org:8080/20770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d2da9d450fba4e789400cfa62927fc25d34f844 Gerrit-Change-Number: 20770 Gerrit-PatchSet: 39 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 08 Mar 2024 23:10:51 +0000 Gerrit-HasComments: Yes
