Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21116 )
Change subject: IMPALA-12835: Fix event processing without hms_event_incremental_refresh_transactional_table ...................................................................... Patch Set 5: (1 comment) > LGTM +1. > Should also run this patch against > hms_event_incremental_refresh_transactional_table=false > against the whole test suite? The tests are still running, will update the review when they are finished. http://gerrit.cloudera.org:8080/#/c/21116/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/21116/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1793 PS4, Line 1793: If flag : // hms_eve > nit: Let's metion that "when incrementalAcidRefresh is false, all txn event Done -- To view, visit http://gerrit.cloudera.org:8080/21116 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I137b289f0e5f7c9c1947e2a3b30258c979f20987 Gerrit-Change-Number: 21116 Gerrit-PatchSet: 5 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Fri, 08 Mar 2024 17:07:41 +0000 Gerrit-HasComments: Yes
