Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 )
Change subject: IMPALA-12426: Query History Table ...................................................................... Patch Set 34: (7 comments) http://gerrit.cloudera.org:8080/#/c/20770/34/be/src/service/workload-management.h File be/src/service/workload-management.h: http://gerrit.cloudera.org:8080/#/c/20770/34/be/src/service/workload-management.h@143 PS34, Line 143: const std::uint32_t remain_char_count = (MAX_VALUES_LENGTH > cur_sql_len) ? line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/20770/34/be/src/util/sql-util.cc File be/src/util/sql-util.cc: http://gerrit.cloudera.org:8080/#/c/20770/34/be/src/util/sql-util.cc@36 PS34, Line 36: const string EscapeSql(std::string::const_iterator iter, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/20770/34/tests/util/memory.py File tests/util/memory.py: http://gerrit.cloudera.org:8080/#/c/20770/34/tests/util/memory.py@20 PS34, Line 20: def assert_byte_str(expected_str, actual_bytes, msg, unit_combined=False, tolerance=0.005): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/20770/34/tests/util/memory.py@20 PS34, Line 20: : flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/20770/34/tests/util/workload_management.py File tests/util/workload_management.py: http://gerrit.cloudera.org:8080/#/c/20770/34/tests/util/workload_management.py@28 PS34, Line 28: def assert_query(query_tbl, client, expected_cluster_id, raw_profile=None, impalad=None, flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/20770/34/tests/util/workload_management.py@514 PS34, Line 514: \ flake8: E502 the backslash is redundant between brackets http://gerrit.cloudera.org:8080/#/c/20770/34/tests/util/workload_management.py@610 PS34, Line 610: def assert_scan_node_metrics(re_metric, profile_lines): flake8: E302 expected 2 blank lines, found 1 -- To view, visit http://gerrit.cloudera.org:8080/20770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d2da9d450fba4e789400cfa62927fc25d34f844 Gerrit-Change-Number: 20770 Gerrit-PatchSet: 34 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 07 Mar 2024 21:17:33 +0000 Gerrit-HasComments: Yes
