Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21029 )
Change subject: IMPALA-12543: Detect self-events before finishing DDL ...................................................................... Patch Set 14: (2 comments) http://gerrit.cloudera.org:8080/#/c/21029/13/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/21029/13/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1090 PS13, Line 1090: + " isRemoved=" + isRemoved); > Can this function be modified to be called multiple times by removing the p Precodition is added to accomodate this comment: https://gerrit.cloudera.org/c/21029/10/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java#1078 >From perspective of call path that track using this >InProgressTableModification, I think the Precondition is good to enforce that >cancelInflightEvent() should always be preceded by registerInflightEvent(). http://gerrit.cloudera.org:8080/#/c/21029/13/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1393 PS13, Line 1393: } finally { > This pattern of checking hasInflightEventRegistration followed by calling c There should only be 1 thread tracking using 1 InProgressTableModification object. The possible concurrent modification is for table_.removeFromVersionsForInflightEvents(), not the cancelInflightEvent() itself. Modified cancelInflightEvent() comment to clarify this. -- To view, visit http://gerrit.cloudera.org:8080/21029 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8365c934349ad21a4d9327fc11594d2fc3445f79 Gerrit-Change-Number: 21029 Gerrit-PatchSet: 14 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Thu, 07 Mar 2024 16:27:12 +0000 Gerrit-HasComments: Yes
