Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/21105 )
Change subject: IMPALA-12845: Crash with DESCRIBE on a complex type from an Iceberg table ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Thanks, Daniel. http://gerrit.cloudera.org:8080/#/c/21105/1/fe/src/main/java/org/apache/impala/analysis/DescribeTableStmt.java File fe/src/main/java/org/apache/impala/analysis/DescribeTableStmt.java: http://gerrit.cloudera.org:8080/#/c/21105/1/fe/src/main/java/org/apache/impala/analysis/DescribeTableStmt.java@105 PS1, Line 105: super.analyze(analyzer); > I wanted to keep 'analyzer_' unset until analysis is done successfully beca I agree, it would be nice to have a common invariant in the future, maybe a flag. Good catch. -- To view, visit http://gerrit.cloudera.org:8080/21105 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5eda21a41167cc1fda183aa16fd6276a6a16f5d3 Gerrit-Change-Number: 21105 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 06 Mar 2024 09:53:37 +0000 Gerrit-HasComments: Yes
