Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21096 )
Change subject: IMPALA-12855: Fix NPE in firing RELOAD events when the partition doesn't exist ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21096/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/21096/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@6799 PS1, Line 6799: List<Long> eventId > >There are no events generated when we are reloading the table Ah, sorry to misunderstood this. That's really a problem! So we shouldn't update lastRefreshEventId using these RELOAD events. The motivation here is to ignore self RELOAD events. I think what we should do is using the same way as detecting self INSERT events - adding the RELOAD event ids to the inflight-events list. -- To view, visit http://gerrit.cloudera.org:8080/21096 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01af3624bf7cf5cd69935cffa28d54f6a6807504 Gerrit-Change-Number: 21096 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Mon, 04 Mar 2024 02:35:28 +0000 Gerrit-HasComments: Yes
