Wenzhe Zhou has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/21015 )

Change subject: IMPALA-12815: Support timestamp for scan predicates for 
external data source table.
......................................................................

IMPALA-12815: Support timestamp for scan predicates
for external data source table.

Binary SCAN predicates involving timestamp literals are pushed down
to remote Database. The current logic assumes ISO 8601 (SQL standard)
format for timestamp literals - 'yyyy-mm-dd hh:mm:ss.ms'

Testing:
- Added custom cluster tests for timestamp predicates with operators:
  '=', '>', '<', '>=', '<=', '!=', 'BETWEEN' for postgres, mysql
  and remote impala.
- Added coverage for timestamp with/without time in the timestamp
- Added coverage for timestamp with/without milliseconds in timestamp.
- Added Planner tests to check predicate pushdown for date/timestamp
  literals, date/timestamp functions and CASTs

Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441
Reviewed-on: http://gerrit.cloudera.org:8080/21015
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Wenzhe Zhou <[email protected]>
---
M fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java
M 
testdata/workloads/functional-planner/queries/PlannerTest/data-source-tables.test
M 
testdata/workloads/functional-query/queries/QueryTest/impala-ext-jdbc-tables-predicates.test
M testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test
M 
testdata/workloads/functional-query/queries/QueryTest/mysql-ext-jdbc-tables.test
5 files changed, 454 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Wenzhe Zhou: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/21015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441
Gerrit-Change-Number: 21015
Gerrit-PatchSet: 17
Gerrit-Owner: gaurav singh <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Reviewer: gaurav singh <[email protected]>

Reply via email to