Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/21015 )
Change subject: IMPALA-12815: Support timestamp for scan predicates for external data source table. ...................................................................... Patch Set 11: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/21015/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21015/11//COMMIT_MSG@10 PS11, Line 10: The timestamp is of the ISO 8601 format(SQL standard): : 'yyyy-mm-dd hh:mm:ss.ms'. It returns the timestamp as : string to the remote database. The description could be improved. Maybe, something like following: "Binary SCAN predicates involving timestamp literals are pushed down to remote Database. The current logic assumes ISO 8601 (SQL standard) format for timestamp literals - 'yyyy-mm-dd hh:mm:ss.ms'" http://gerrit.cloudera.org:8080/#/c/21015/11//COMMIT_MSG@19 PS11, Line 19: - Added coverage for timestamp with/without milliseconds in timestamp. Also, include: "Added Planner tests to check predicate pushdown for date/timestamp literals, date/timestamp functions and CASTs" -- To view, visit http://gerrit.cloudera.org:8080/21015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6ffe672b4027e2cee094cec4f99b9df9308e441 Gerrit-Change-Number: 21015 Gerrit-PatchSet: 11 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Tue, 27 Feb 2024 00:19:32 +0000 Gerrit-HasComments: Yes
