Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20951 )
Change subject: IMPALA-12598: Allow multiple equality field id lists for Iceberg tables ...................................................................... Patch Set 5: Code-Review+1 (2 comments) Nice change, LGTM! http://gerrit.cloudera.org:8080/#/c/20951/5/testdata/data/README File testdata/data/README: http://gerrit.cloudera.org:8080/#/c/20951/5/testdata/data/README@850 PS5, Line 850: primary key(i) Impala doesn't do anything with this clause, right? http://gerrit.cloudera.org:8080/#/c/20951/5/testdata/workloads/functional-planner/queries/PlannerTest/iceberg-v2-tables.test File testdata/workloads/functional-planner/queries/PlannerTest/iceberg-v2-tables.test: http://gerrit.cloudera.org:8080/#/c/20951/5/testdata/workloads/functional-planner/queries/PlannerTest/iceberg-v2-tables.test@1583 PS5, Line 1583: cardinality=8 Would be nice to fix IMPALA-11797 later to get better cardinalities. Or, if fixing the generic case is risky, at least we could do it for equality deletes, similarly to IMPALA-12371. -- To view, visit http://gerrit.cloudera.org:8080/20951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e52d7a5800bf1b479f0c234679be92442d09f79 Gerrit-Change-Number: 20951 Gerrit-PatchSet: 5 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 20 Feb 2024 18:52:50 +0000 Gerrit-HasComments: Yes
