Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21005 )
Change subject: IMPALA-12790: Fix overestimation in ScanNode.getInputCardinality ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/21005/6/fe/src/main/java/org/apache/impala/planner/ScanNode.java File fe/src/main/java/org/apache/impala/planner/ScanNode.java: http://gerrit.cloudera.org:8080/#/c/21005/6/fe/src/main/java/org/apache/impala/planner/ScanNode.java@336 PS6, Line 336: > It would be good to add comments describing the high-level logic of the fun Done. Added more java doc comment for the function. http://gerrit.cloudera.org:8080/#/c/21005/6/fe/src/main/java/org/apache/impala/util/MaxRowsProcessedVisitor.java File fe/src/main/java/org/apache/impala/util/MaxRowsProcessedVisitor.java: http://gerrit.cloudera.org:8080/#/c/21005/6/fe/src/main/java/org/apache/impala/util/MaxRowsProcessedVisitor.java@54 PS6, Line 54: > Would it be simpler to use scan.hasSimpleLimit() directly since hasSimpleLi Done -- To view, visit http://gerrit.cloudera.org:8080/21005 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icc5b39a7684fb8748185349d0b80baf8dcd6b126 Gerrit-Change-Number: 21005 Gerrit-PatchSet: 7 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 12 Feb 2024 16:29:06 +0000 Gerrit-HasComments: Yes
