Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20866 )
Change subject: IMPALA-12412: Support partition evolution in OPTIMIZE statement ...................................................................... Patch Set 5: (5 comments) Not a full review yet. http://gerrit.cloudera.org:8080/#/c/20866/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20866/5//COMMIT_MSG@9 PS5, Line 9: in Nit: on? http://gerrit.cloudera.org:8080/#/c/20866/5//COMMIT_MSG@9 PS5, Line 9: OPTIMIZE Nit: The OPTIMIZE statement. http://gerrit.cloudera.org:8080/#/c/20866/5//COMMIT_MSG@26 PS5, Line 26: setting Nit: "setting the" http://gerrit.cloudera.org:8080/#/c/20866/5//COMMIT_MSG@36 PS5, Line 36: Are these tabs? http://gerrit.cloudera.org:8080/#/c/20866/5/fe/src/main/java/org/apache/impala/analysis/OptimizeStmt.java File fe/src/main/java/org/apache/impala/analysis/OptimizeStmt.java: http://gerrit.cloudera.org:8080/#/c/20866/5/fe/src/main/java/org/apache/impala/analysis/OptimizeStmt.java@47 PS5, Line 47: tableRef_ Doesn't 'tableRef_' need to be reset? It is also set during 'analyze()'. -- To view, visit http://gerrit.cloudera.org:8080/20866 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65a0c8529d274afff38ccd582f1b8a857716b1b5 Gerrit-Change-Number: 20866 Gerrit-PatchSet: 5 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 09 Feb 2024 16:22:26 +0000 Gerrit-HasComments: Yes
