Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21001 )
Change subject: IMPALA-11568: Fix SamplingTimeSeriesCounter not correctly cleared ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/21001/1/be/src/util/streaming-sampler.h File be/src/util/streaming-sampler.h: http://gerrit.cloudera.org:8080/#/c/21001/1/be/src/util/streaming-sampler.h@49 PS1, Line 49: Reset > resetting initial_period_ is missing here; I wonder if it's an omission, 'initial_period_' keeps the parameter value we got from the constructor. It's used to reset 'period_'. So after Reset(), everything comes back to the state of just constructing this instance. http://gerrit.cloudera.org:8080/#/c/21001/1/be/src/util/streaming-sampler.h@105 PS1, Line 105: period_; > This member seems to be unused (besides being initialized in the constructo It's used to reset 'period_'. I'll add a comment. -- To view, visit http://gerrit.cloudera.org:8080/21001 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8bc2c94ad96899522b288708fcaf7413d4b99fa1 Gerrit-Change-Number: 21001 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 07 Feb 2024 23:13:53 +0000 Gerrit-HasComments: Yes
