Yida Wu has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/21000 )
Change subject: IMPALA-12721: Fix flaky tests involving check_deleted_file_fd() ...................................................................... IMPALA-12721: Fix flaky tests involving check_deleted_file_fd() check_deleted_file_fd() is introduced in IMPALA-12681, however some spilling testcases involving check_deleted_file_fd() seem flaky. This patch fixed the issue by adding a retry mechanism within the check_deleted_file_fd() function. If the function encounters a failure, it retries the process of verifying the presence of a deleted referencing file. Based on my local test, the file will be removed after the test even when the test fails and the call to delete the file handle is ahead of the call to remove the file (This has been confirmed through additional testing logs). While there is no theory why this would happen, introducing a retry mechanism has allowed the test case to run successfully for 200 times without encountering any failures. It is possible that a delay may be occurring at some point in the process which leads to this kind of failure. Tests: Reran the testcase 200 times without a failure. Change-Id: I900aab7dc9833015ce140253ff40da28a6ed3ba6 --- M tests/custom_cluster/test_scratch_disk.py 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/21000/3 -- To view, visit http://gerrit.cloudera.org:8080/21000 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I900aab7dc9833015ce140253ff40da28a6ed3ba6 Gerrit-Change-Number: 21000 Gerrit-PatchSet: 3 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]>
