Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20922 )

Change subject: IMPALA-12726: Simulate large-scale query in 
TpcdsCpuCostPlannerTest
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20922/6/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java:

http://gerrit.cloudera.org:8080/#/c/20922/6/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1758
PS6, Line 1758:             
analyzer.getQueryOptions().getReplica_preference().equals(
              :                 TReplicaPreference.REMOTE) ?
              :                 analyzer.numExecutorsForPlanning() :
> This is test only (planner_testcase_mode==true). HDFS minicluster only have
Ack. I missed the check at L1744.



--
To view, visit http://gerrit.cloudera.org:8080/20922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaffddd70c2da8376ca6c40f65606bbac46c34de7
Gerrit-Change-Number: 20922
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Sun, 04 Feb 2024 22:13:48 +0000
Gerrit-HasComments: Yes

Reply via email to