Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 )
Change subject: IMPALA-12426: Query History Table ...................................................................... Patch Set 16: (2 comments) http://gerrit.cloudera.org:8080/#/c/20770/12/be/src/benchmarks/expr-benchmark.cc File be/src/benchmarks/expr-benchmark.cc: http://gerrit.cloudera.org:8080/#/c/20770/12/be/src/benchmarks/expr-benchmark.cc@591 PS12, Line 591: // prettyprint_duration 5.67 5.67 5.67 0.048X 0.0475X 0.0471X > I did not modify any of the code for those functions. Thus, it is either a Might be slower now due to IMPALA-12373 (short string optimization). I will ask around. http://gerrit.cloudera.org:8080/#/c/20770/16/be/src/service/workload-management.cc File be/src/service/workload-management.cc: http://gerrit.cloudera.org:8080/#/c/20770/16/be/src/service/workload-management.cc@635 PS16, Line 635: default: : break; nit: optional: this can be made more robust by also handling other TCatalogOpType that should be inserted to WM table. The default then can be changed to return error status or LOG error for unknown TCatalogOpType (meaning new TCatalogOpType has been added since today). I gave similar comment to handle new TStmtType.UNKNOWN at https://gerrit.cloudera.org/c/20956/2..8/be/src/service/client-request-state.cc#b317 -- To view, visit http://gerrit.cloudera.org:8080/20770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d2da9d450fba4e789400cfa62927fc25d34f844 Gerrit-Change-Number: 20770 Gerrit-PatchSet: 16 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 30 Jan 2024 18:55:11 +0000 Gerrit-HasComments: Yes
