Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20922 )
Change subject: IMPALA-12726: Simulate large-scale query in TpcdsCpuCostPlannerTest ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/20922/1/fe/src/main/java/org/apache/impala/common/RuntimeEnv.java File fe/src/main/java/org/apache/impala/common/RuntimeEnv.java: http://gerrit.cloudera.org:8080/#/c/20922/1/fe/src/main/java/org/apache/impala/common/RuntimeEnv.java@100 PS1, Line 100: > nit: "tables with their" Done http://gerrit.cloudera.org:8080/#/c/20922/1/fe/src/test/java/org/apache/impala/planner/TpcdsCpuCostPlannerTest.java File fe/src/test/java/org/apache/impala/planner/TpcdsCpuCostPlannerTest.java: http://gerrit.cloudera.org:8080/#/c/20922/1/fe/src/test/java/org/apache/impala/planner/TpcdsCpuCostPlannerTest.java@53 PS1, Line 53: / Granular scan limit that will injected into individual ScanNode of tables. : private static Map< > Looks like some dim tables are also scaled but not linearly. I'll check TPC ps2 fully inject all stats based on actual dataset instead of just scaling them. -- To view, visit http://gerrit.cloudera.org:8080/20922 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaffddd70c2da8376ca6c40f65606bbac46c34de7 Gerrit-Change-Number: 20922 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 29 Jan 2024 16:36:58 +0000 Gerrit-HasComments: Yes
