Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20867 )
Change subject: IMPALA-12688: Support JSON profile imports for visualizing query timeline in webUI ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/20867/2/www/queries.tmpl File www/queries.tmpl: http://gerrit.cloudera.org:8080/#/c/20867/2/www/queries.tmpl@215 PS2, Line 215: <h3 id="imported_queries_header"> Add a tool tip to explain what this section is about like line 97. http://gerrit.cloudera.org:8080/#/c/20867/2/www/queries.tmpl@216 PS2, Line 216: Imported Queries I think "Imported Query Profiles" is more accurate. http://gerrit.cloudera.org:8080/#/c/20867/2/www/queries.tmpl@219 PS2, Line 219: <span class="btn btn-primary">Import JSON Profile</span> Not sure if it is Mac/Chrome specific, but I can not multi-select several json files for import at the same time. Query page also immediately scrolled to the top after clicking Import button. It will be nice if page can stay at Imported Queries section. http://gerrit.cloudera.org:8080/#/c/20867/2/www/queries.tmpl@264 PS2, Line 264: var dbOpenReq = indexedDB.open("imported_queries"); This looks like persisted in browser even after refresh page or minicluster restart. How to clear all imported profiles without clicking the individual delete button? Also, test manually by importing 2 profile, delete them all, import again, and sometimes it does not work the second time. http://gerrit.cloudera.org:8080/#/c/20867/2/www/queries.tmpl@378 PS2, Line 378: console.log("Error parsing JSON profile"); I think it should be displayed to user as text somewhere in query page. -- To view, visit http://gerrit.cloudera.org:8080/20867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife6eb59bf2030fd19fc92aaf134eb51c609e04d0 Gerrit-Change-Number: 20867 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 24 Jan 2024 01:04:04 +0000 Gerrit-HasComments: Yes
