Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 )
Change subject: IMPALA-12426: Query History Table ...................................................................... Patch Set 7: (26 comments) http://gerrit.cloudera.org:8080/#/c/20770/7/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/20770/7/be/src/service/impala-server.h@1282 PS7, Line 1282: /// be limited and failing inserts do not retry indefinitely. line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/20770/7/be/src/service/workload-management.cc File be/src/service/workload-management.cc: http://gerrit.cloudera.org:8080/#/c/20770/7/be/src/service/workload-management.cc@551 PS7, Line 551: << "STORED AS iceberg TBLPROPERTIES ('schema_version'='1.0.0','format_version'='2')"; line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/20770/7/tests/custom_cluster/test_query_log.py File tests/custom_cluster/test_query_log.py: http://gerrit.cloudera.org:8080/#/c/20770/7/tests/custom_cluster/test_query_log.py@39 PS7, Line 39: class TestQueryLogTable(CustomClusterTestSuite): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/20770/7/tests/custom_cluster/test_query_log.py@56 PS7, Line 56: \ flake8: E502 the backslash is redundant between brackets http://gerrit.cloudera.org:8080/#/c/20770/7/tests/custom_cluster/test_query_log.py@279 PS7, Line 279: 1 flake8: E225 missing whitespace around operator http://gerrit.cloudera.org:8080/#/c/20770/7/tests/custom_cluster/test_query_log.py@283 PS7, Line 283: 1 flake8: E225 missing whitespace around operator http://gerrit.cloudera.org:8080/#/c/20770/7/tests/custom_cluster/test_query_log.py@287 PS7, Line 287: 1 flake8: E225 missing whitespace around operator http://gerrit.cloudera.org:8080/#/c/20770/7/tests/custom_cluster/test_query_log.py@298 PS7, Line 298: 1 flake8: E225 missing whitespace around operator http://gerrit.cloudera.org:8080/#/c/20770/7/tests/custom_cluster/test_query_log.py@309 PS7, Line 309: 1 flake8: E225 missing whitespace around operator http://gerrit.cloudera.org:8080/#/c/20770/7/tests/custom_cluster/test_query_log.py@316 PS7, Line 316: ) flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/20770/7/tests/custom_cluster/test_query_log.py@319 PS7, Line 319: 1 flake8: E225 missing whitespace around operator http://gerrit.cloudera.org:8080/#/c/20770/7/tests/custom_cluster/test_query_log.py@368 PS7, Line 368: \ flake8: E502 the backslash is redundant between brackets http://gerrit.cloudera.org:8080/#/c/20770/7/tests/custom_cluster/test_query_log.py@389 PS7, Line 389: e flake8: F841 local variable 'e' is assigned to but never used http://gerrit.cloudera.org:8080/#/c/20770/7/tests/custom_cluster/test_query_log.py@394 PS7, Line 394: \ flake8: E502 the backslash is redundant between brackets http://gerrit.cloudera.org:8080/#/c/20770/7/tests/custom_cluster/test_query_log.py@434 PS7, Line 434: e flake8: F841 local variable 'e' is assigned to but never used http://gerrit.cloudera.org:8080/#/c/20770/7/tests/custom_cluster/test_query_log.py@588 PS7, Line 588: @ flake8: E301 expected 1 blank line, found 0 http://gerrit.cloudera.org:8080/#/c/20770/7/tests/custom_cluster/test_query_log.py@590 PS7, Line 590: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/20770/7/tests/custom_cluster/test_query_log.py@627 PS7, Line 627: = flake8: E225 missing whitespace around operator http://gerrit.cloudera.org:8080/#/c/20770/7/tests/custom_cluster/test_query_log.py@628 PS7, Line 628: @ flake8: E301 expected 1 blank line, found 0 http://gerrit.cloudera.org:8080/#/c/20770/7/tests/custom_cluster/test_query_log.py@660 PS7, Line 660: \ flake8: E502 the backslash is redundant between brackets http://gerrit.cloudera.org:8080/#/c/20770/7/tests/custom_cluster/test_query_log.py@681 PS7, Line 681: @ flake8: E301 expected 1 blank line, found 0 http://gerrit.cloudera.org:8080/#/c/20770/7/tests/custom_cluster/test_query_log.py@720 PS7, Line 720: flake8: W292 no newline at end of file http://gerrit.cloudera.org:8080/#/c/20770/7/tests/util/memory.py File tests/util/memory.py: http://gerrit.cloudera.org:8080/#/c/20770/7/tests/util/memory.py@39 PS7, Line 39: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/20770/7/tests/util/memory.py@39 PS7, Line 39: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/20770/7/tests/util/retry.py File tests/util/retry.py: http://gerrit.cloudera.org:8080/#/c/20770/7/tests/util/retry.py@22 PS7, Line 22: def retry(func, max_attempts=3, sleep_time_s=1, backoff=2, raise_immediately=False): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/20770/7/tests/util/retry.py@69 PS7, Line 69: - flake8: E226 missing whitespace around arithmetic operator -- To view, visit http://gerrit.cloudera.org:8080/20770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d2da9d450fba4e789400cfa62927fc25d34f844 Gerrit-Change-Number: 20770 Gerrit-PatchSet: 7 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 16 Jan 2024 21:35:00 +0000 Gerrit-HasComments: Yes
