Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20876 )
Change subject: IMPALA-12566: Fix RpcMgrKerberizedTest on RedHat 8 ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/20876/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20876/1//COMMIT_MSG@18 PS1, Line 18: During : negotiation, Kudu RPC will call GetFQDN to retrieve the FQDN In this context, I guess Impala might benefit by cherry-picking this patch: https://github.com/apache/kudu/commit/3932a7780b8005b7204b3058302600ea67cd1f2b http://gerrit.cloudera.org:8080/#/c/20876/1//COMMIT_MSG@24 PS1, Line 24: 'hostname' man pages nit: there is a manual page for /etc/hosts itself; it can be found at list at https://man7.org/linux/man-pages/man5/hosts.5.html http://gerrit.cloudera.org:8080/#/c/20876/1/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/20876/1/bin/bootstrap_system.sh@458 PS1, Line 458: $(hostname) > Should this be explicit to $(hostname -f) ? nit: referring to https://man7.org/linux/man-pages/man1/hostname.1.html might be more authoritative -- To view, visit http://gerrit.cloudera.org:8080/20876 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1eb24f9faec766e388d793408aedecdc92107185 Gerrit-Change-Number: 20876 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 11 Jan 2024 16:53:30 +0000 Gerrit-HasComments: Yes
