Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20863 )
Change subject: IMPALA-12643 (part 2): Fallback to safe libraries on error in resolve_minidumps.py ...................................................................... IMPALA-12643 (part 2): Fallback to safe libraries on error in resolve_minidumps.py Since resolve_minidumps.py's call to minidump_stackwalk can go haywire due to bad symbols in shared libraries, this adds a fallback mechanism where it tries again with a "safe" list of shared libraries. These are limited to the ones that make the most difference in resolving minidumps (libc, libstdc++, and libjvm). The list of safe libraries can be customized via the --safe_library_list. Testing: - Verified that this uses the fallback on Centos 7 and resolves the minidumps successfully. Change-Id: I6bb4c9f65f9c27bb3b86c7ff2f3a6a48e258ef01 Reviewed-on: http://gerrit.cloudera.org:8080/20863 Reviewed-by: Michael Smith <[email protected]> Tested-by: Joe McDonnell <[email protected]> --- M bin/resolve_minidumps.py 1 file changed, 73 insertions(+), 21 deletions(-) Approvals: Michael Smith: Looks good to me, approved Joe McDonnell: Verified -- To view, visit http://gerrit.cloudera.org:8080/20863 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6bb4c9f65f9c27bb3b86c7ff2f3a6a48e258ef01 Gerrit-Change-Number: 20863 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]>
