Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20791 )
Change subject: IMPALA-9375: Remove DirectMetaProvider usage from CatalogMetaProvider ...................................................................... Patch Set 2: Code-Review+1 (5 comments) http://gerrit.cloudera.org:8080/#/c/20791/2/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/20791/2/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@743 PS2, Line 743: if (lastCompactionId > 0) { request.setLastCompactionId(lastCompactionId); } nit: don't need brackets "{}" for one-line statement. http://gerrit.cloudera.org:8080/#/c/20791/2/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@759 PS2, Line 759: if (ci != null) { partNameToCompactionId.put(unPartitionedName, ci.getId()); } nit: don't need brackets "{}" http://gerrit.cloudera.org:8080/#/c/20791/2/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/20791/2/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@1019 PS2, Line 1019: } It'd be helpful to keep logging the time taken for checking the latest compaction info. I.e. the logging in MetastoreShim#checkLatestCompaction(). http://gerrit.cloudera.org:8080/#/c/20791/2/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@1713 PS2, Line 1713: private static final String UNPARTITIONED_NAME = ""; > Used in checkLatestCompaction method. We can use HdfsTable.DEFAULT_PARTITION_NAME which is the name of default partition for unpartitioned tables. http://gerrit.cloudera.org:8080/#/c/20791/2/fe/src/main/java/org/apache/impala/service/JniCatalog.java File fe/src/main/java/org/apache/impala/service/JniCatalog.java: http://gerrit.cloudera.org:8080/#/c/20791/2/fe/src/main/java/org/apache/impala/service/JniCatalog.java@568 PS2, Line 568: MetaStoreUtil.getNullPartitionKeyValue(msClient.getHiveClient())); > HMS may be restarted with new "hive.exec.default.partition.name" value. I t Ack -- To view, visit http://gerrit.cloudera.org:8080/20791 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I096c1b1d1a52e979c8b2d8173dae9ca2cc6c36d2 Gerrit-Change-Number: 20791 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Sat, 30 Dec 2023 05:28:44 +0000 Gerrit-HasComments: Yes
