Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/20473 )
Change subject: IMPALA-11553: Add event specific metrics in the table metrics ...................................................................... Patch Set 9: (5 comments) http://gerrit.cloudera.org:8080/#/c/20473/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20473/2//COMMIT_MSG@22 PS2, Line 22: Tests: > I think the lag of event processing at table level will be helpful. It show Ack. Created https://issues.apache.org/jira/browse/IMPALA-12664 to track this. http://gerrit.cloudera.org:8080/#/c/20473/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20473/5//COMMIT_MSG@11 PS5, Line 11: identif > I see, so this is simply how Impala treats gauges and not something specifi Yeah, that's correct. http://gerrit.cloudera.org:8080/#/c/20473/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20473/8//COMMIT_MSG@11 PS8, Line 11: metric > typo Ack http://gerrit.cloudera.org:8080/#/c/20473/8//COMMIT_MSG@23 PS8, Line 23: - Manually verified the metrics on catalogD UI page when running some > Can we add a simple test in tests/webserver/test_web_pages.py to fetch the Ack http://gerrit.cloudera.org:8080/#/c/20473/8/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/20473/8/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2529 PS8, Line 2529: return droppedPartitions_; > If we return here, we should bump the counter of EVENTS_SKIPPED_METRIC. Ack -- To view, visit http://gerrit.cloudera.org:8080/20473 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2428029361e610a0fcd8ed11be2ab771f03b00dd Gerrit-Change-Number: 20473 Gerrit-PatchSet: 9 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Fri, 22 Dec 2023 00:06:16 +0000 Gerrit-HasComments: Yes
