Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20612 )
Change subject: IMPALA-3825: Delegate runtime filter aggregation to some executors ...................................................................... Patch Set 18: Code-Review+2 (3 comments) just some nits for the tests, feel free to merge after resolving them http://gerrit.cloudera.org:8080/#/c/20612/18/tests/query_test/test_runtime_filters.py File tests/query_test/test_runtime_filters.py: http://gerrit.cloudera.org:8080/#/c/20612/18/tests/query_test/test_runtime_filters.py@486 PS18, Line 486: work nit: works http://gerrit.cloudera.org:8080/#/c/20612/18/tests/query_test/test_runtime_filters.py@503 PS18, Line 503: ' nit: +2 indentation http://gerrit.cloudera.org:8080/#/c/20612/18/tests/query_test/test_runtime_filters.py@517 PS18, Line 517: result.data[0] = '620' is this supposed to be an assert? -- To view, visit http://gerrit.cloudera.org:8080/20612 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11d38ed0f223d6e5b32a19ebe725af7738ee4ab0 Gerrit-Change-Number: 20612 Gerrit-PatchSet: 18 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 20 Dec 2023 07:12:34 +0000 Gerrit-HasComments: Yes
