Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20612 )
Change subject: IMPALA-3825: Delegate runtime filter aggregation to some executors ...................................................................... Patch Set 14: (5 comments) http://gerrit.cloudera.org:8080/#/c/20612/14/be/src/runtime/query-state.cc File be/src/runtime/query-state.cc: http://gerrit.cloudera.org:8080/#/c/20612/14/be/src/runtime/query-state.cc@271 PS14, Line 271: // Making a copy of the "filepath to hosts" mapping into std library types. This comment doesn't really explain why this is necessary. http://gerrit.cloudera.org:8080/#/c/20612/14/be/src/runtime/runtime-filter-bank.h File be/src/runtime/runtime-filter-bank.h: http://gerrit.cloudera.org:8080/#/c/20612/14/be/src/runtime/runtime-filter-bank.h@107 PS14, Line 107: /// selected as intermediate filter aggregator to help coordinator. Besides of doing nit: remove "of", so it says "Besides doing" http://gerrit.cloudera.org:8080/#/c/20612/14/be/src/runtime/runtime-filter-bank.h@108 PS14, Line 108: /// local aggregation, each intermediate aggregators will also listen and aggregate grammar: "each intermediate aggregator will" http://gerrit.cloudera.org:8080/#/c/20612/14/be/src/runtime/runtime-filter-bank.h@109 PS14, Line 109: /// filter update from at most MAX_NUM_FILTERS_AGGREGATED_PER_HOST-1 other executors. "filter updates from" http://gerrit.cloudera.org:8080/#/c/20612/14/be/src/runtime/runtime-filter-bank.h@110 PS14, Line 110: /// Intermediate aggregator then send the aggregated filter update to coordinator for "then sends the" -- To view, visit http://gerrit.cloudera.org:8080/20612 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11d38ed0f223d6e5b32a19ebe725af7738ee4ab0 Gerrit-Change-Number: 20612 Gerrit-PatchSet: 14 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 13 Dec 2023 21:49:58 +0000 Gerrit-HasComments: Yes
