Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/20473 )
Change subject: IMPALA-11553: Add event specific metrics in the table metrics ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/20473/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20473/5//COMMIT_MSG@11 PS5, Line 11: identif > Where are the durations set? Are there also larger durations tracked, e.g. MetastoreEventsProcessor.java#1168 -- We are tracking the duration in seconds. I'm wondering if the event processor would take an hour/day to consume an event. Seconds seem to be more realistic to me. http://gerrit.cloudera.org:8080/#/c/20473/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/20473/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1534 PS5, Line 1534: // event > It would be nice to reduce code duplication related to the timer. We seem t Ack http://gerrit.cloudera.org:8080/#/c/20473/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1536 PS5, Line 1536: lf-event > getTableNoThrow() would let us skip the try/ catch block Ack http://gerrit.cloudera.org:8080/#/c/20473/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1745 PS5, Line 1745: > What will happen with the timer after drop/rename events? Will we able to s Unfortunately, since the table doesn't exist in cache we cannot see the duration of event processing for a dropped table on the web UI -- To view, visit http://gerrit.cloudera.org:8080/20473 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2428029361e610a0fcd8ed11be2ab771f03b00dd Gerrit-Change-Number: 20473 Gerrit-PatchSet: 6 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Tue, 12 Dec 2023 23:18:43 +0000 Gerrit-HasComments: Yes
