Hello Zoltan Borok-Nagy, Peter Rozsa, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20769
to look at the new patch set (#6).
Change subject: IMPALA-12589: Ignore FbFileDesc.absolutePath() if it is
null/empty
......................................................................
IMPALA-12589: Ignore FbFileDesc.absolutePath() if it is null/empty
IMPALA-11507 add absolute_path field to FbFileDesc in
CatalogObjects.fbs. This field is used as a fallback for the
relative_path field when the relative path of an Iceberg data file
cannot be obtained by the table location path. relative_path is never
set with null, while absolute_path may not be set and left as null.
IMPALA-11507 missed a case where both FileDescriptor.getRelativePath()
and FbFileDesc.absolutePath() are null/empty. This patch fixes the bug
so that FileDescriptor.getPath() and FileDescriptor.getAbsolutePath() do
not fall back to FbFileDesc.absolutePath() if it is null/empty. With
this fix, FileDescriptor.getPath() and FileDescriptor.getAbsolutePath()
will not return null.
Testing:
- Add test_scanner.py::TestSingleFileTable
- Pass core tests
Change-Id: I15d811430871cd1319d9560901318c1c3b89403c
---
M fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java
M tests/query_test/test_scanners.py
2 files changed, 63 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/20769/6
--
To view, visit http://gerrit.cloudera.org:8080/20769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15d811430871cd1319d9560901318c1c3b89403c
Gerrit-Change-Number: 20769
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
