Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20754 )
Change subject: IMPALA-12595: Allow automatic removal of old logs from previous PID ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/20754/6/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/20754/6/bin/start-impala-cluster.py@293 PS6, Line 293: result += ["-log_rotation_match_pid=true"] > Is '=1' equivalent to '=true'? Seems like an odd way to declare it. Change to '=true' http://gerrit.cloudera.org:8080/#/c/20754/6/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/20754/6/tests/common/custom_cluster_test_suite.py@311 PS6, Line 311: cmd.append('--ignore_pid_on_log_rotation') > This seems like excessive plumbing when you could just pass "impalad_args=- I choose to control this by adding option in start-impala-cluster.py because default behavior of impalad after this patch is to ignore PID, but test minicluster still need to match PID. This is why ignore_pid_on_log_rotation default to False in this script and start-impala-cluster.py. Without dedicated ignore_pid_on_log_rotation option in start-impala-cluster.py, '-log_rotation_match_pid=true' need to be a mandatory option in build_logging_args(), and TestLogging will have its impalad started with confusing successive flags: "-ignore_pid_on_log_rotation=true -ignore_pid_on_log_rotation=false" -- To view, visit http://gerrit.cloudera.org:8080/20754 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I599799e73f27f941a1d7f3dec0f40b4f05ea5ceb Gerrit-Change-Number: 20754 Gerrit-PatchSet: 7 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 08 Dec 2023 22:35:54 +0000 Gerrit-HasComments: Yes
