Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20485 )
Change subject: IMPALA-10949: Improve batching logic of partition events ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/20485/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20485/3//COMMIT_MSG@7 PS3, Line 7: IMPALA-10949: Improve batching logic of partition : events nit: put the title in one line http://gerrit.cloudera.org:8080/#/c/20485/3/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/20485/3/tests/custom_cluster/test_events_custom_configs.py@403 PS3, Line 403: EventProcessorUtils.wait_for_event_processing(self) Can we also verify all events are skipped? The metric of "events-skipped" can be checked. -- To view, visit http://gerrit.cloudera.org:8080/20485 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e79510739347cbe669719a9e4cb9cabd5daa7d3 Gerrit-Change-Number: 20485 Gerrit-PatchSet: 3 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Fri, 08 Dec 2023 02:34:52 +0000 Gerrit-HasComments: Yes
