Hi All - Not sure why one of our devs did this, but he created a new review, chose a diff to upload, and then entered a "-1" for the Perforce change number. This resulted in a review being created (the number of "Open" reviews in the left pane of his dashboard increased), but the review isn't listed in the main pane.
Two questions: 1) Should the logic be modified so that a negative integer isn't valid, and the review creation would then error out? Alternatively, the logic could handle a negative value and display the review normally. 2) If, by design, a review CAN be created using a negative value as the change #, but is hidden, is there a way to see/edit/delete the review (other than a DB hack)? I've attached a screenshot showing the user's dashboard for reference. Thanks much! -Will <https://lh3.googleusercontent.com/-2-LPvuolqP4/WnM6znT3Y7I/AAAAAAAAIxU/HMKDGM9-bVE2-2KSNhaJGKxKPkcqUwhJgCLcBGAs/s1600/rb_negative_value.png> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
