Hi Tanvir, The P4 module would be server-side, and the Perforce support 100% needs the P4 module. However, if the /grid/ is any indication, you have some non-default sort of packaging setup there, which I can't really help with much. You'd have to locate the path where the Review Board modules are being installed and look for the P4 there. You'd have to run Python under that environment. Someone at your company would know more about that, I'm sure.
Christian On Tue, Jun 27, 2017 at 10:34 AM, Tanvir Kazmi <[email protected]> wrote: > Hi Christian, > > I see the following on our Review Board website: Review Board 2.5.6.1 > We do review board post by running: > /grid/common/pkgs/python/v2.7.2/bin/rbt post --target-people=lbansal > --bugs-closed 1721498 -p 9380 > > So, the post call is done by executing python v2.7.2. We do have several > versions of python installed on the network, but I check, rbt_post is found > ONLY under v2.7.2 so I guess that's the python version, question is what's > the P4Python version, if any being used. > > On the machine where review board is running, I only see the following > under /usr/lib: > /usr/lib/python2.4/ > > So, no later versions. So, I am confused. Does Review Board post > absolutely need P4Python to run, or is it running in our setup without > using that interface by making direct P4 calls? > > Thanks, > Tanvir > > On Tuesday, June 27, 2017 at 10:37:32 PM UTC+5:30, Christian Hammond wrote: >> >> Hi Tanvir, >> >> Are you sure Review Board is being run under Python 2.7? Could it be >> under 2.6? I would expect the P4 import to work. Check the site-packages >> directories /usr/lib/python-2.6/site-packages and 2.7/site-packages/ to >> see if you can find P4* and ReviewBoard* >> >> Christian >> >> >> >> On Tue, Jun 27, 2017 at 04:50 Tanvir Kazmi <[email protected]> wrote: >> >>> Hi Christian, >>> >>> I tried to figure out the p4python version using the following as >>> advised on Perforce page for the same. >>> https://www.perforce.com/perforce/r16.2/user/p4pythonnotes.txt >>> >>> To display the version of P4Python you have installed, >>> start Python and issue the following commands: >>> >>> >>> import P4 >>> >>> print(P4.P4.identify()) >>> >>> >>> cmweb2: /home/tkazmi> /grid/common/pkgs/python/v2.7.2/bin/python >>> Python 2.7.2 (default, Mar 26 2013, 18:57:24) >>> [GCC 4.4.4 20100726 (Red Hat 4.4.4-13)] on linux2 >>> Type "help", "copyright", "credits" or "license" for more information. >>> >>> >>> import P4 >>> Traceback (most recent call last): >>> File "<stdin>", line 1, in <module> >>> ImportError: No module named P4 >>> >>> I am assuming we must be having some version of P4Python installed since >>> we are able to post and view reviews just fine for non-task streams, but >>> not sure which one. >>> >>> Can you recommend which version of P4Python should we move to? I guess >>> it would be ok to stay with python 2.7.2 since it says it is compatible >>> with P4Python 2010.1 or later. >>> >>> Thanks, >>> Tanvir >>> >>> >>> On Tuesday, June 27, 2017 at 4:29:34 AM UTC+5:30, Christian Hammond >>> wrote: >>> >>>> Hi Tanvir, >>>> >>>> Can you confirm the version of p4python you have installed on the >>>> Review Board server? How recently was that installed? >>>> >>>> Christian >>>> >>> On Mon, Jun 26, 2017 at 11:24 AM, Tanvir Kazmi <[email protected]> >>>> wrote: >>>> >>> Hi, >>>>> >>>>> I tried posting a review by specifying a Perforce changelist from a >>>>> 'task stream' client. The review submission went fine, but the review did >>>>> not load up the relevant file in the RB web interface, showing up an error >>>>> as below. Can someone confirm if Perforce task streams are supported in >>>>> Review Board? >>>>> >>>>> rbt post for review happened fine as seen below. >>>>> /grid/common/pkgs/python/v2.7.2/bin/rbt post --target-people=lbansal >>>>> --bugs-closed 1721498 -p 9065 >>>>> Generating diff for pending changeset 9065 >>>>> Review request #138799 posted. >>>>> >>>>> >>>>> However, when opening the diff online, it showed an error of the form: >>>>> http://reviewboard/reviews/r/138799/diff/1/ >>>>> >>>>> //avs/t_2027/nc_test/etc/C_Macros.hppa >>>>> There was an error displaying this diff. >>>>> The patch to '//avs/t_2027/nc_test/etc/C_Macros.hppa' didn't apply >>>>> cleanly. The temporary files have been left in '/tmp/reviewboard.mYtZ9l' >>>>> for debugging purposes. >>>>> `patch` returned: >>>>> This may be a bug in the software, a temporary outage, or an issue >>>>> with the format of your diff. >>>>> Please try again, and if you still have trouble, contact support. >>>>> >>>> -- >>>>> Supercharge your Review Board with Power Pack: >>>>> https://www.reviewboard.org/powerpack/ >>>>> Want us to host Review Board for you? Check out RBCommons: >>>>> https://rbcommons.com/ >>>>> Happy user? Let us know! https://www.reviewboard.org/users/ >>>>> --- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "reviewboard" group. >>>>> >>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>> >>>> >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>> >>>> >>>> >>>> -- >>>> Christian Hammond >>>> President/CEO of Beanbag <https://www.beanbaginc.com/> >>>> Makers of Review Board <https://www.reviewboard.org/> >>>> >>> -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "reviewboard" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- >> -- >> Christian Hammond >> President/CEO of Beanbag >> Makers of Review Board >> > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
