Yes we were using post-review in 1.5x and RBTools now. By class I meant
.java file.
for example:
(Because of confidentiality I can not post actual data)
1.5.x:
Index: /Project/com/package/subpackage/Example.java
--- Example.java
/file/location/base#/file/location//Project/com/package/subpackage/Example.java#<version
number>
+++ Example.java <timestamp>
This format is shown perfectly on our legacy site 1.5 which we still
support to get back to the old diffs if needed, which are more than 30k,
but if I try to publish it in the new one 2.5.6 the following exception is
shown:
There was an error displaying this diff.
The patch to 'Example.java' didn't apply cleanly. The temporary files have
been left in '/tmp/reviewboard.6Gy2Xh' for debugging purposes.
`patch` returned:
This may be a bug in the software, a temporary outage, or an issue
with the format of your diff.
Please try again, and if you still have trouble,
contact support.
Traceback (most recent call last):
File
"/usr/lib/python2.7/site-packages/ReviewBoard-2.5.6.1-py2.7.egg/reviewboard/diffviewer/views.py",
line 275, in get
response = renderer.render_to_response(request)
File
"/usr/lib/python2.7/site-packages/ReviewBoard-2.5.6.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
line 56, in render_to_response
return HttpResponse(self.render_to_string(request))
File
"/usr/lib/python2.7/site-packages/ReviewBoard-2.5.6.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
line 74, in render_to_string
large_data=True)
File
"/usr/lib/python2.7/site-packages/Djblets-0.9.3-py2.7.egg/djblets/cache/backend.py",
line 295, in cache_memoize
compress_large_data))
File
"/usr/lib/python2.7/site-packages/Djblets-0.9.3-py2.7.egg/djblets/cache/backend.py",
line 249, in cache_memoize_iter
items = items_or_callable()
File
"/usr/lib/python2.7/site-packages/Djblets-0.9.3-py2.7.egg/djblets/cache/backend.py",
line 292, in <lambda>
lambda: [lookup_callable()],
File
"/usr/lib/python2.7/site-packages/ReviewBoard-2.5.6.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
line 73, in <lambda>
lambda: self.render_to_string_uncached(request),
File
"/usr/lib/python2.7/site-packages/ReviewBoard-2.5.6.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
line 87, in render_to_string_uncached
request=request)
File
"/usr/lib/python2.7/site-packages/ReviewBoard-2.5.6.1-py2.7.egg/reviewboard/diffviewer/diffutils.py",
line 429, in populate_diff_chunks
chunks = list(generator.get_chunks())
File
"/usr/lib/python2.7/site-packages/ReviewBoard-2.5.6.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
line 756, in get_chunks
for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
File
"/usr/lib/python2.7/site-packages/ReviewBoard-2.5.6.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
line 107, in get_chunks
large_data=True)
File
"/usr/lib/python2.7/site-packages/Djblets-0.9.3-py2.7.egg/djblets/cache/backend.py",
line 295, in cache_memoize
compress_large_data))
File
"/usr/lib/python2.7/site-packages/Djblets-0.9.3-py2.7.egg/djblets/cache/backend.py",
line 249, in cache_memoize_iter
items = items_or_callable()
File
"/usr/lib/python2.7/site-packages/Djblets-0.9.3-py2.7.egg/djblets/cache/backend.py",
line 292, in <lambda>
lambda: [lookup_callable()],
File
"/usr/lib/python2.7/site-packages/ReviewBoard-2.5.6.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
line 106, in <lambda>
lambda: list(self.get_chunks_uncached()),
File
"/usr/lib/python2.7/site-packages/ReviewBoard-2.5.6.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
line 763, in get_chunks_uncached
new = get_patched_file(old, self.filediff, self.request)
File
"/usr/lib/python2.7/site-packages/ReviewBoard-2.5.6.1-py2.7.egg/reviewboard/diffviewer/diffutils.py",
line 232, in get_patched_file
return patch(diff, buffer, filediff.dest_file, request)
File
"/usr/lib/python2.7/site-packages/ReviewBoard-2.5.6.1-py2.7.egg/reviewboard/diffviewer/diffutils.py",
line 168, in patch
'output': stderr,
Exception: The patch to 'Example.java' didn't apply cleanly. The temporary
files have been left in '/tmp/reviewboard.6Gy2Xh' for debugging purposes.
`patch` returned:
Anyway, in the 2.5.6 site version the are not any issues with uploading of
new diff files, neither from perforce (using RBTools) nor from our custom
source repository (after I rewrite the parser to match the new standard ).
But the incompatibility is curious.
Best regards,
Kristiyan
--
Supercharge your Review Board with Power Pack:
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons:
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
