Hey Kevin, Your script is going through and checking the source_file attribute of the files, but the source file will be the "Was ..." filename, rather than the new name. Can you try checking dest_file? Maybe that's what you're hitting.
Christian -- Christian Hammond President/CEO of Beanbag <https://www.beanbaginc.com/> Makers of Review Board <https://www.reviewboard.org/> On Mon, Mar 20, 2017 at 3:02 PM, Kevin Yu <[email protected]> wrote: > I just did a quick simple test, I svn rm and svn add some files and then i > run my script again. this time, i am able to get the file id.. > > I did a compare with the review request i had issue with. The only > difference is that the files in the original review request involve svn > merge. In this case, the api doesn't return the file id. > Please see the screenshot below. > > > <https://lh3.googleusercontent.com/-Fk8E5uZFIKE/WNBRPscrr6I/AAAAAAAAClQ/RhXQJbrtj34HVQvICDAE1Ki3MAnL7g39QCLcB/s1600/Selection_001.bmp> > > > On Monday, March 13, 2017 at 2:33:02 PM UTC-7, Kevin Yu wrote: > >> My Workflow when rbt patch fail because of file conflicts: >> Get Review Request by ID -> review_request.get_diffs() and from the >> return, i get the file id by matching the filename. With the file id, my >> script will create an issue against this file to indicate there's merge >> conflicts. >> >> It works for all the modified files. However, I noticed the get_diffs() >> *doesn't* contain the files that are added or removed from this review >> request. Is there any other way to get the file id for the added or removed >> files from the diff? >> > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
