Thanks for your kindly advises Barret :)

We use RBTool 0.7.9 and the script svn-hook-postcommit-review 
<https://github.com/reviewboard/reviewboard/blob/master/contrib/tools/svn-hook-postcommit-review>
 
from RB's github repository, we changed it a little because the "
--revision-range" command changed from RBTool 0.6.x. Maybe this hook could 
get an official updates for further RB users.

Regards,
Bill.

在 2017年1月18日星期三 UTC+8上午10:08:21,Barret Rennie写道:
>
> Bill,
>
> Ah OK that makes more sense. I'm not sure if we have the resources to 
> devote to developing and supporting dynamic web hook URLs in RB itself. 
> Theoretically you could reuse most of the existing webhook framework in an 
> extension to send to a custom URL.
>
> Also if you're using post-review you are using a very out of date version 
> of RBTools. Newer versions have a command "rbt post" which has superseded 
> "post-review".
>
> Regards,
> Barret Rennie
>
> On Tue, 17 Jan, 2017 at 8:04 PM, Bill Hoo <[email protected] <javascript:>> 
> wrote:
>
>
> Hi Barret,
>
> Yes it is, the {issuekey} is a bug ID in JIRA, which looks like 
> {MYPROJECT-123}, and we customized the official post-commit script with 
> RBTools to post it as the bug number on the review request. After that we 
> can click the "Bugs" field and jump into JIRA very happpy.
>
> But the question is how to know which review request is bound to a JIRA 
> issue if we're in JIRA at the first place, so we need a feature like 
> "Dynamic WebHooks" to posts comment on the issue when review request 
> published.
>
> BTW, as Christian said before, we can try to implement an extension by 
> ourselves, but I still expecting an official one, that's cool.
>
> Thanks in advance,
> Bill.
>
> 在 2017年1月18日星期三 UTC+8上午9:43:59,Barret Rennie写道:
>>
>> Hi Bill,
>>
>> What exactly would {issueKey} be? Is that the bug number on the review 
>> request?
>>
>> Regards,
>> Barret
>>
>> On Tue, 17 Jan, 2017 at 7:41 PM, Bill Hoo <[email protected]> wrote:
>>
>> Hi Christian,
>>
>> Thanks for the reply. If we search in this group or Google, we can find a 
>> lot of questions like "How to integrate ReviewBoard and JIRA?", if dynamic 
>> URL still a technical problem, can we provide an official extension for 
>> this feature or at least a plan on it? After all JIRA is a popular bug 
>> tracker used by lots of companies.
>>
>> Best regards,
>> Bill.
>>
>>
>> 在 2017年1月18日星期三 UTC+8上午8:09:52,Christian Hammond写道:
>>>
>>> (Hrm. I wrote this days ago and apparently never sent it. Sorry!)
>>>
>>> Hi Bill,
>>>
>>> Thanks for the kind words :)
>>>
>>> WebHooks today don't have any kind of dynamic URL support. What would 
>>> "{issuekey}" come from in Review Board?
>>>
>>> An option is to build a simple extension that listens for the necessary 
>>> signals (like published review requests, etc.) and invokes the URL itself 
>>> with the necessary payload. Another would be to have a script somewhere 
>>> that the webhook POSTs to that then turns around and forwards to that URL 
>>> on JIRA.
>>>
>>> Christian
>>>
>>> -- 
>>> Christian Hammond
>>> President/CEO of Beanbag <https://www.beanbaginc.com/>
>>> Makers of Review Board <https://www.reviewboard.org/>
>>>
>>>
>>>
>>> On Sat, Jan 14, 2017 at 6:42 PM, Bill Hoo <[email protected]> wrote:
>>>
>>>> Hi guys,
>>>>
>>>> Thanks for your great job on ReviewBoard! It's nice and easy to use!
>>>>
>>>> We use ReviewBoard 2.5.7 for our code review workflow, we need comment 
>>>> on JIRA issues with every review event, and JIRA REST API2 need a URL like 
>>>> this:
>>>>
>>>> http://MYJIRAHOST/rest/api/2/issue/{issuekey}/comment
>>>>
>>>> Which means the {issuekey} is a variable. But ReviewBoard's WebHooks' 
>>>> URL seems a single hardcoded string, how can we handle the {issuekey} 
>>>> thing?
>>>>
>>>> Best regards!
>>>> Bill.
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> -- 
>>>>
>>>>
>>>> Supercharge your Review Board with Power Pack: 
>>>> https://www.reviewboard.org/powerpack/
>>>>
>>>>
>>>> Want us to host Review Board for you? Check out RBCommons: 
>>>> https://rbcommons.com/
>>>>
>>>>
>>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>>>
>>>>
>>>> --- 
>>>>
>>>>
>>>> You received this message because you are subscribed to the Google 
>>>> Groups "reviewboard" group.
>>>>
>>>>
>>>> To unsubscribe from this group and stop receiving emails from it, send 
>>>> an email to [email protected].
>>>>
>>>>
>>>> For more options, visit https://groups.google.com/d/optout.
>>>>
>>>>
>>>>
>>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to [email protected].
>> For more options, visit https://groups.google.com/d/optout.
>>
>> -- 
> Supercharge your Review Board with Power Pack: 
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons: 
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> --- 
> You received this message because you are subscribed to the Google Groups 
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to [email protected] <javascript:>.
> For more options, visit https://groups.google.com/d/optout.
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to