This is a known bug which is fixed in the 2.5 releases. We may do another 2.0.x release at some point, in which case it will be included there as well.
-David On Wed, Nov 11, 2015 at 12:05 PM, Californian <[email protected]> wrote: > Thank you for the quick reply. Really appreciate! > > Yes, I created a request from the list of committed changes. And I checked > the log. I think I might know what's going on here. > > We were unable to see the list of committed changes in the beginning. It's > because we are running GitLab 7.1.1 (a little behind of the latest > version). We had to modify gitlab.py file under /usr/lib/python2.7/site- > packages/reviewboard/hostingsvcs. In the original gitlab.py, in line 249, > it had message=item['message'] which does not match our current > gitlab (7.1.1) has. So, we replaced message=item['message'] with > message=item['title']. > > After this modification, we are able to see the list of committed changes. > > I think we might need to change other Review Board related .py script as > well to match the change we made. Any suggestions? I understand changing > the original .py files in Review Board is not a good idea. But before we > upgrade to the new version of GitLab, this might be the only solution we > have. Any suggestion is appreciated. > > By the way, here are the errors I see in the log: > > - Unable to update new review request from commit ID > c4a817a2e2d48f6dea74903a1eb42efe8e6cd84b: u'message' > Traceback (most recent call last): > File "/usr/lib/python2.7/site-packages/reviewboard/reviews/managers.py", > line 150, in create > review_request.update_from_commit_id(commit_id) > File > "/usr/lib/python2.7/site-packages/reviewboard/reviews/models/base_review_request_details.py", > line 194, in update_from_commit_id > self.update_from_committed_change(commit_id) > File > "/usr/lib/python2.7/site-packages/reviewboard/reviews/models/base_review_request_details.py", > line 238, in update_from_committed_change > commit = self.repository.get_change(commit_id) > File "/usr/lib/python2.7/site-packages/reviewboard/scmtools/models.py", > line 434, in get_change > return hosting_service.get_change(self, revision) > File "/usr/lib/python2.7/site-packages/reviewboard/hostingsvcs/gitlab.py", > line 298, in get_change > message = commit['message'] > > KeyError: u'message' > > Thank you again for the help! > > > > On Wednesday, November 11, 2015 at 11:14:53 AM UTC-8, David Trowbridge > wrote: >> >> Are you creating this review request from the list of committed changes? >> If so, something is going wrong during that step and it's not downloading >> the diff correctly. Can you check the logs for errors? >> >> -David >> On Wed, Nov 11, 2015 at 11:12 AM Californian <[email protected]> wrote: >> >>> Hi, >>> >>> I am setting up the Review Board for our team. I have installed and >>> configured the Review Board v2.0.18 on a system with CentOS 7. We are using >>> GitLab v7.1.1. >>> >>> I am able to link the repo from GitLab with Review Board. Under my repo, >>> I am also able to see committed changes in "New Review Request for Pending >>> Change": "master" branch (from the drop down menu). After creating a Review >>> Request, I can't find a way to view the diff. >>> >>> After reading the Review Board Manual/Doc closely, I realized in the >>> Review Request, two tabs are missing on the review request action bar. >>> According to the Doc, it has six tabs on the review request action bar. But >>> I only see four tabs: Close, Update, Review, and Ship It! Please see the >>> attached screenshot. >>> >>> Apparently, we are missing the most important tab "View Diff". It seems >>> something is wrong with the Diff Viewer in our Review Board system. >>> >>> Any ideas what we are missing in our installation or configuration? Any >>> info is appreciated. >>> >>> Thanks! >>> >>> -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "reviewboard" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- >> -David > > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
