Ah, the actual old-school screenshot feature. We haven't enabled uploading of new screenshots in the UI since I think 1.6.x? Maybe 1.7.x. We've replaced it with general support for file attachments. Given that, it's likely we had a regression in backwards-compatibility for old screenshots.
Would you mind filing a bug about this ( https://hellosplat.com/s/beanbag/tickets/new/?project=reviewboard), and including all the information, along with the screenshot, that you mentioned in this thread? Thanks! - Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On Thu, Nov 5, 2015 at 2:22 AM, John McGowan <john.mcgow...@gmail.com> wrote: > > <https://lh3.googleusercontent.com/-CdRw9xoTgrE/VjsszwDDxoI/AAAAAAAAAFk/fqKD_S_5jC4/s1600/RB2.jpg> > > > <https://lh3.googleusercontent.com/-IhzuE17TkPY/VjsrmOMCOTI/AAAAAAAAAFY/R_sqNpl0Q1g/s1600/RB1.jpg> > > Hi Christian, It was 2.8.1 so I put it up to 2.9.0. New reviews with > attached files are showing ok but not already submitted reviews with > attached files. > > This is what I'm seeing (sorry about the formatting, seems to want to > attached pictures to the top of this reply!), thumbnails are ok (see > RB1.jpg). RB2.jpg is all i get when I click through. > On an existing review and a new file being attached they are showing. Note > the directory contents and how the files are being created, which could be > how it is being done now (directory 05 is new working ones, the rest are > just the filename without that string prepended). > > [root@bfs-dl360g7-53-xm2 05]# ls -l ../04 > total 176 > -rwxr-xr-x 1 apache apache 175469 Nov 4 12:18 CC_SNMPTrap.jmx > [root@bfs-dl360g7-53-xm2 05]# ls -lt > total 2124 > -rw-r--r-- 1 apache apache 19925 Nov 5 10:18 > d6c586a5-aedd-4d9a-8783-00001883ea48__RB1_300.jpg > -rw-r--r-- 1 apache apache 57912 Nov 5 10:18 > d6c586a5-aedd-4d9a-8783-00001883ea48__RB1_600.jpg > -rw-r--r-- 1 apache apache 23472 Nov 5 10:18 > d6c586a5-aedd-4d9a-8783-00001883ea48__RB1.jpg > -rw-r--r-- 1 apache apache 40951 Nov 5 10:09 > b452a6ba-c754-42a0-bf8e-0996f336d0cb__RB_300.jpg > -rw-r--r-- 1 apache apache 146216 Nov 5 10:09 > b452a6ba-c754-42a0-bf8e-0996f336d0cb__RB_600.jpg > -rw-r--r-- 1 apache apache 316166 Nov 5 10:09 > b452a6ba-c754-42a0-bf8e-0996f336d0cb__RB.jpg > -rw-r--r-- 1 apache apache 40951 Nov 5 10:08 > 00170ca0-2613-49fc-a181-1e3cd644f8e2__RB_300.jpg > -rw-r--r-- 1 apache apache 146216 Nov 5 10:08 > 00170ca0-2613-49fc-a181-1e3cd644f8e2__RB_600.jpg > -rw-r--r-- 1 apache apache 316166 Nov 5 10:08 > 00170ca0-2613-49fc-a181-1e3cd644f8e2__RB.jpg > -rw-r--r-- 1 apache apache 40951 Nov 5 09:45 > 6e7e858f-9498-4c1a-869d-396185f582a8__RB_300.jpg > -rw-r--r-- 1 apache apache 146216 Nov 5 09:45 > 6e7e858f-9498-4c1a-869d-396185f582a8__RB_600.jpg > -rw-r--r-- 1 apache apache 316166 Nov 5 09:45 > 6e7e858f-9498-4c1a-869d-396185f582a8__RB.jpg > -rw-r--r-- 1 apache apache 40951 Nov 5 09:40 > 429f1b9d-c7fe-4faf-bfdf-65d3984a197b__RB_300.jpg > -rw-r--r-- 1 apache apache 146216 Nov 5 09:40 > 429f1b9d-c7fe-4faf-bfdf-65d3984a197b__RB_600.jpg > -rw-r--r-- 1 apache apache 316166 Nov 5 09:40 > 429f1b9d-c7fe-4faf-bfdf-65d3984a197b__RB.jpg > > > > > On Thursday, 5 November 2015 00:08:49 UTC, Christian Hammond wrote: >> >> Hi John, >> >> What version of Pillow do you have installed? If you have 3.0.0, there >> are some bugs that can be problematic in production. If this is the case, >> try downgrading to 2.9.0. >> >> The message in the log there is harmless. Just a deprecation warning for >> us. >> >> Christian >> >> -- >> Christian Hammond - chri...@beanbaginc.com >> Review Board - https://www.reviewboard.org >> Beanbag, Inc. - https://www.beanbaginc.com >> >> On Wed, Nov 4, 2015 at 4:06 PM, John McGowan <john.m...@gmail.com> wrote: >> >>> Hi Christian/all, >>> >>> Has anyone else noticed clicking on an screenshot thumbnail on an >>> existing review is not displaying the item. Working ok on a 1.6.16 to >>> 2.0.20 but not when going up to 2.5.1.1. >>> >>> error_log has this when i click on it: >>> >>> [Thu Nov 05 00:02:48 2015] [error] >>> /usr/lib/python2.6/site-packages/ReviewBoard-2.5.1.1-py2.6.egg/reviewboard/reviews/markdown_utils.py:40: >>> DeprecationWarning: reviewboard.reviews.markdown_utils.markdown_escape is >>> deprecated. Please use djblets.markdown.markdown_escape. >>> [Thu Nov 05 00:02:48 2015] [error] DeprecationWarning) >>> >>> >>> >>> - John >>> >>> -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "reviewboard" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to reviewboard...@googlegroups.com. >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
