Could I ask what the source code looks like for this? thanks Mark
On Saturday, January 7, 2012 at 1:14:10 AM UTC-5, Christian Hammond wrote: > > It wouldn't take much work for us to add context to this. Just +/- a > couple of lines when determining the range. We'd probably want to somehow > make it clear that it's context and not the affected code, though. That > would maybe require a little more thought. > > Christian > > -- > Christian Hammond - [email protected] <javascript:> > Review Board - http://www.reviewboard.org > VMware, Inc. - http://www.vmware.com > > > On Fri, Jan 6, 2012 at 6:44 PM, Chris Tooley <[email protected] > <javascript:>> wrote: > >> We actually have the same issues and do use multi-line comments. >> Multi-line comments are fit when the comment applies to the whole block in >> our case. I see what you mean, but it's a confusing option to use for us. >> On Jan 6, 2012 8:01 PM, "David Trowbridge" <[email protected] >> <javascript:>> wrote: >> >>> We don't show additional context right now (I suppose we could consider >>> adding >>> such an option), but are you aware of multi-line comments? If the comment >>> applies to a block of code more than one line in length, you can click >>> and drag >>> to specify all the relevant lines. This lets the reviewer decide how >>> much context >>> is necessary, and if you're not using it already, would probably go a >>> long way >>> towards solving your problem. >>> >>> -David >>> >>> >>> On Fri, Jan 6, 2012 at 5:24 PM, Marco <[email protected] <javascript:> >>> > wrote: >>> >>>> Hi, >>>> >>>> here we all love RB, and use it happily. >>>> However, there's one feature missing that drives us nuts: in review >>>> mode, when going through the reviewer's comments, only the actual line >>>> the comment is relative to is displayed. >>>> >>>> Often, it would be very useful to be able to see the 'context' of the >>>> line (eg, a couple of lines above and below) but we seem unable to >>>> find an option that would allow us to enable that, so we're assuming >>>> that's not possible. >>>> >>>> One colleagues suggested, as a workaround, that we have 3 monitors: >>>> one for the review, one for the diff, and the third for Eclipse/emacs/ >>>> vim whatever - is that about right? >>>> >>>> If you guys could implement this (or suggest a workaround that does >>>> not treble our IT budget) that'd be most appreciated! >>>> >>>> Thanks, >>>> Marco. >>>> >>>> -- >>>> Want to help the Review Board project? Donate today at >>>> http://www.reviewboard.org/donate/ >>>> Happy user? Let us know at http://www.reviewboard.org/users/ >>>> -~----------~----~----~----~------~----~------~--~--- >>>> To unsubscribe from this group, send email to >>>> [email protected] <javascript:> >>>> For more options, visit this group at >>>> http://groups.google.com/group/reviewboard?hl=en >>>> >>> >>> -- >>> Want to help the Review Board project? Donate today at >>> http://www.reviewboard.org/donate/ >>> Happy user? Let us know at http://www.reviewboard.org/users/ >>> -~----------~----~----~----~------~----~------~--~--- >>> To unsubscribe from this group, send email to >>> [email protected] <javascript:> >>> For more options, visit this group at >>> http://groups.google.com/group/reviewboard?hl=en >> >> -- >> Want to help the Review Board project? Donate today at >> http://www.reviewboard.org/donate/ >> Happy user? Let us know at http://www.reviewboard.org/users/ >> -~----------~----~----~----~------~----~------~--~--- >> To unsubscribe from this group, send email to >> [email protected] <javascript:> >> For more options, visit this group at >> http://groups.google.com/group/reviewboard?hl=en >> > > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
