The former (files are fetched on demand to keep the dub size down, and cached for a while to make things fast).
-David On Thu, May 21, 2015 at 3:21 AM unknown <[email protected]> wrote: > So after the review request is uploaded, when a user views the diff, the > files are brought from the repo and then displayed? > Or is the entire file content saved in the database, which is fetched and > displayed? > > > On Saturday, April 25, 2015 at 1:32:33 AM UTC+5:30, David Trowbridge wrote: > >> That error is coming from the server (the server is trying to log >> in--it's not downloading credentials to the client). It can't use your >> credentials from the client because it also needs to communicate with the >> repository when people view the diff. >> >> -David >> > On Thu, Apr 23, 2015 at 9:04 PM unknown <[email protected]> wrote: >> > When i give the worng credentials in RB repository page and try to post >>> from cmd promt (i.e. rbt post) , it fails as shown : >>> >>> http://localhost:8080/reviewboard/api/review-requests/180/diffs/ >>> ERROR: Error uploading diff >>> >>> >>> One or more fields had errors (HTTP 400, API Error 105) >>> >>> path: [P4#run] Errors during command execution( "p4 login" ) >>> >>> [Error]: "Access for user 'wrong_userid' has not been enabled by >>> 'p4 protect'. >>> " >>> >>> Your review request still exists, but the diff is not attached. >>> >>> http://localhost:8080/reviewboard/r/180/ >>> >>> So it tries to log into SCM using ReviewBoard repository login details, >>> right ? >>> why cant it just take it from my local machine ? >>> >>> >>> On Thursday, April 23, 2015 at 4:18:26 PM UTC+5:30, unknown wrote: >>>> >>>> Hi >>>> >>>> why does rbt post have to fetch SCM credentials from RB and not just my >>>> client m/c >>>> >>>> rbt diff takes perforce login details from client machine and why cant >>>> rbt post do the same? >>>> >>>> And where exactly is the function where it fetches the login from >>>> Review Board site ? >>>> >>>> Tnx >>>> >>> -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "reviewboard" group. >>> >> To unsubscribe from this group and stop receiving emails from it, send an >>> email to [email protected]. >> >> >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
