This is the case because if you apply rev #2 to the upstream code, those lines are present, and if you apply rev #6 to the upstream code, those lines are also present (so there's no difference between them). If you view the interdiff between 1 and 6, you should see those lines as added.
-David On Thu, Nov 20, 2014 at 4:25 PM, Andrew MacLeod <[email protected]> wrote: > The scenario is as follow. > > In the first diff posting (rev #1) of a review, lines 5-10 are removed in > one particular file. There are lots of other changes in this file and > others. > > In the second diff posting (rev #2) of the review, the lines are added > back in. > > We get several more diff postings on this review until we are at rev#6. > Now if you look at the > inter-diff changes from rev #2 -> rev #6, the addition of lines 5-10 does > *not* show as an addition > (ie. in green) on the right hand panel of the diff screen. > > I can argue why that is the case but my question is this intended > behavior? > > Thanks, > > -amac > > -- > Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ > --- > Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ > --- > Happy user? Let us know at http://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
