Hi Hardik, Review Board does not push code to your repository. For that matter, it never alters your repository.
When a review request is marked as submitted, that means someone has pushed the code to the repository. The pushing of the code is still up to a developer to do. If there’s a central person who is responsible for pushing the changes, what he can do is, using RBTools, run: $ rbt patch <review request ID> $ svn commit Then the review request can be marked as submitted, either through the web UI, or using: $ rbt close —close-type submitted <review request ID> Through custom post-commit hooks on the SVN repository, closing the review request can even be automated when the code is pushed. We don’t provide any SVN post-commit hooks for this right now, but you can use this as a reference for building your own: https://github.com/reviewboard/rbtools/blob/master/contrib/tools/git-hook-set-submitted Hope that helps clear things up. Christian -- Christian Hammond - [email protected] Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On September 3, 2014 at 11:00:56 AM, hardik shah ([email protected]) wrote: Hello All, I have Configured Review-board for Code-Review Purposes. I am facing an issue while using Review-Board with SVN. Basically, I am trying to Achieve below mentioned flow. 1) User checks-out the code from SVN 2) Make some change in the code. 3) use RB tools to generate the review request. 4) Log-in into RB server 5) All other Reviewers will review the changes. 6) Once the Review is done,Changes must be submitted by Admin-user of Review Board. 7) Once Admin-user submits the request, changes must be committed to SVN I was successfully able to run steps 1 - 6. But once Admin-user submits the changes, the changes are not committed to SVN, I am not sure why changes are not committed to SVN. I don't see any logs or error-messages for the same. Environment Info : OS: Ubuntu Review-board Version . 2.0.6 Any links or Knowledge-sharing will be Great Regards, Hardik Shah -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
