Hello, i am trying to post a review with RBTools 0.5.2 and it insists on finding a file which is not in the repo anymore. The problem is that i think that the file nonexistence is correct, so the question is why rbt post is trying to find it.
I have removed a certain 3rd party library from a project (git rm) and adopted a different library (git add) which has different API but the same subsystem - it's an iOS zipping lib. So down in the lib, there are essentially the same files, only at different paths. Git, being clever as always, has put a single rename entry in the diff, instead of separate removal and add. Now rbtools is trying to access the former file. I had a look at line 390 of /Library/Python/2.7/site-packages/rbtools/commands/post.py but lacking any Python experience, i am trying this newsgroup before attempting to follow and debug the calls there - i guess this one: review_request.get_diffs().upload_diff(diff_content, **diff_kwargs) -------------------------------------------------------------------- rbt post --branch branch-name --revision-range=ebc3e2d...:f45e91e... --summary=... --description=>... --debug DEBUG:root:Running: git config --get reviewboard.url DEBUG:root:Making HTTP GET request to https://server/rb/api/ DEBUG:root:Making HTTP GET request to https://server/rb/api/info/ DEBUG:root:Running: git merge-base origin/develop refs/heads/develop DEBUG:root:Running: git branch -r --contains ebc3e2d... DEBUG:root:Running: git diff --no-color --full-index --no-ext-diff --ignore-submodules --no-renames ebc3e2d..f45e91e... -M DEBUG:root:Making HTTP GET request to https://server/api/review-requests/ DEBUG:root:Making HTTP POST request to https://server/rb/api/review-requests/ DEBUG:root:Making HTTP GET request to https://server/rb/api/review-requests/4936/diffs/ DEBUG:root:Making HTTP POST request to https://server/rb/api/review-requests/4936/diffs/ DEBUG:root:Got API Error 207 (HTTP code 400): The file was not found in the repository DEBUG:root:Error data: {u'stat': u'fail', u'file': u'client-iOS/Endorsed/ObjectiveZip/MiniZip/crypt.h', u'err': {u'msg': u'The file was not found in the repository', u'code': 207}, u'revision': u''} Traceback (most recent call last): File "/usr/local/bin/rbt", line 9, in <module> load_entry_point('RBTools==0.5.2', 'console_scripts', 'rbt')() File "/Library/Python/2.7/site-packages/rbtools/commands/main.py", line 106, in main command.run_from_argv([RB_MAIN] + args) File "/Library/Python/2.7/site-packages/rbtools/commands/__init__.py", line 157, in run_from_argv exit_code = self.main(*args) or 0 File "/Library/Python/2.7/site-packages/rbtools/commands/post.py", line 511, in main submit_as=self.options.submit_as) File "/Library/Python/2.7/site-packages/rbtools/commands/post.py", line 390, in post_request raise CommandError('\n'.join(error_msg)) rbtools.commands.CommandError: Error uploading diff The file was not found in the repository (HTTP 400, API Error 207) Your review request still exists, but the diff is not attached. ------------------------------------------------------------- git diff --no-color --full-index --no-ext-diff --ignore-submodules --no-renames ebc3e2d..f45e91e... -M Relevant part of the output: diff --git a/client-iOS/Endorsed/ObjectiveZip/MiniZip/crypt.h b/client-iOS/Endorsed/ZipArchive/minizip/crypt.h old mode 100755 new mode 100644 similarity index 97% rename from client-iOS/Endorsed/ObjectiveZip/MiniZip/crypt.h rename to client-iOS/Endorsed/ZipArchive/minizip/crypt.h index 622f4bc2ec45de7c2916f64c22b7bfbc203f8809..f14a628b4c7cbdb5bf8e9795405719f8f767cfc5 --- a/client-iOS/Endorsed/ObjectiveZip/MiniZip/crypt.h +++ b/client-iOS/Endorsed/ZipArchive/minizip/crypt.h @@ -1,132 +1,132 @@ -/* crypt.h -- base code for crypt/uncrypt ZIPfile ... followed by whole former code prepended by minuses +/* crypt.h -- base code for crypt/uncrypt ZIPfile ... followed by whole new code prepended by pluses -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
